Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate after_config hook callback #371

Merged

Conversation

sumaiyamannan
Copy link
Contributor

It should go into a new branch

@sumaiyamannan sumaiyamannan force-pushed the MOODLE_405_STABLE branch 3 times, most recently from 631a0fd to 62d26c5 Compare November 4, 2024 01:10
@danmarsden danmarsden changed the base branch from MOODLE_35_STABLE to MOODLE_403_STABLE November 13, 2024 20:27
@danmarsden
Copy link
Member

Thanks Sumaiya - looks like your new branch supports 4.3 and higher so I've created a 403_STABLE branch in the repo and pointed this PR at that branch - but can you pleashttps://github.com/catalyst/moodle-tool_excimer?tab=readme-ov-file#branchese add a line to the readme table here for this new 403 branch in this commit
https://github.com/catalyst/moodle-tool_excimer?tab=readme-ov-file#branches

and - can we flag it as supporting the 405 stable branch here?
https://github.com/catalyst/moodle-tool_excimer/pull/371/files#diff-0dc418129946563e59bb69680a5ef0ded4329ed9e56e3d295c25e12ea726726bR31

@sumaiyamannan
Copy link
Contributor Author

I have addressed the comments.

Change readme and version
@danmarsden danmarsden merged commit ed66035 into catalyst:MOODLE_403_STABLE Nov 14, 2024
15 checks passed
@TomoTsuyuki
Copy link
Contributor

Hi @sumaiyamannan @danmarsden

It looks the core\hook\after_config hook is from 4.5.
https://tracker.moodle.org/browse/MDL-79011

The branch name should be MOODLE_405_STABLE, and supported version should be 4.5+.

@TomoTsuyuki
Copy link
Contributor

I added the callback for older version of Moodle #373

@sumaiyamannan
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants