[#935] Update docs regarding memory leak (4.5)

.github/workflows/ci.yml

@@ -18,3 +18,4 @@ jobs:
           sudo sed -i 's/azure\.//' /etc/apt/sources.list
           sudo apt-get update
           sudo apt-get install -y graphviz;
+          sudo fc-cache

classes/form/dataflow_form.php

@@ -109,9 +109,9 @@ public function definition() {
             'loghandlers',
             get_string('log_handlers', 'tool_dataflows'),
             [
-                log_handler::BROWSER_CONSOLE => get_string('log_handler_browser_console', 'tool_dataflows'),
                 log_handler::FILE_PER_DATAFLOW => get_string('log_handler_file_per_dataflow', 'tool_dataflows'),
                 log_handler::FILE_PER_RUN => get_string('log_handler_file_per_run', 'tool_dataflows'),
+                log_handler::BROWSER_CONSOLE => get_string('log_handler_browser_console', 'tool_dataflows'),
             ]
         );
         $select->setMultiple(true);

classes/helper.php

@@ -305,7 +305,7 @@ public static function extract_http_headers(string $content) {
         }
         // HTTP/1.1 defines the sequence CR LF as the end-of-line marker for all
         // protocol elements except the entity-body (see appendix 19.3 for tolerant applications).
-        // See https://datatracker.ietf.org/doc/html/rfc2616#section-2.2
+        // See https://datatracker.ietf.org/doc/html/rfc2616#section-2.2.
         $lines = explode("\n", str_replace("\r\n", "\n", $content));
         $headerlines = [];
         $current = null;

lang/en/tool_dataflows.php

@@ -46,10 +46,11 @@
 $string['gpg_key_dir'] = 'Path to keyring directory';
 $string['gpg_key_dir_desc'] = 'Path to keyring directory';
 $string['log_handlers'] = 'Log handlers';
-$string['log_handlers_desc'] = 'Additional log handlers to output dataflow logs to more destinations. The handler for mtrace is always active and cannot be disabled. Applying the settings at the dataflow level will override settings applied at the site admin level.';
+$string['log_handlers_desc'] = 'Additional log handlers to output dataflow logs to more destinations. The handler for mtrace is always active and cannot be disabled. Applying the settings at the dataflow level will override settings applied at the site admin level.<br/>
+Note - The browser developer console handler is not recommended for dataflows that output a large amount of logs, as it will consume large amounts of memory. It also sends dataflow logs to the users developer console which will be visible by them, which may be undesirable.';
 $string['log_handler_file_per_dataflow'] = 'File per dataflow - [dataroot]/tool_dataflows/Ymd_{dataflowid}.log';
 $string['log_handler_file_per_run'] = 'File per run - [dataroot]/tool_dataflows/{dataflowid}/Ymd_his_{runid}.log';
-$string['log_handler_browser_console'] = 'Browser Console';
+$string['log_handler_browser_console'] = 'Browser Developer Console';
 $string['permitted_dirs'] = 'Permitted directories';
 $string['permitted_dirs_desc'] = "List directories here to allow them to be read from/written to by dataflow steps.
     One directory per line. Each directory must be an absolute path. You can use the place holder '{\$a}' for the

version.php

@@ -25,8 +25,8 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2024111500;
-$plugin->release = 2024111500;
+$plugin->version = 2025021100;
+$plugin->release = 2025021100;
 $plugin->requires = 2024100700;    // Our lowest supported Moodle (4.5.0).
 $plugin->supported = [405, 405];
 $plugin->component = 'tool_dataflows';