Moved cookies to temp request dir for parallel workers #193 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanheywood
force-pushed
the
cookies
branch
4 times, most recently
from
0377ab6 to
cd96d14
Compare
bwalkerl
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks @brendanheywood
I haven't ran this locally but it looks good in theory. Just a couple of small issues.
settings.php
Outdated
| 1 => new lang_string('debugnormal', 'tool_crawler'), | ||
| 2 => new lang_string('debugverbose', 'tool_crawler'), | ||
| ]; | ||
| $settings->add(new admin_setting_configselect('tool_crawler/debyugging', |
brendanheywood
force-pushed
the
cookies
branch
from
cd96d14 to
7a934e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.