Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdP Initiated login failing since update to SimpleSAMLPHP 2.0.5 #801

Closed
jwalits opened this issue Feb 29, 2024 · 0 comments · Fixed by #802
Closed

IdP Initiated login failing since update to SimpleSAMLPHP 2.0.5 #801

jwalits opened this issue Feb 29, 2024 · 0 comments · Fixed by #802

Comments

@jwalits
Copy link
Contributor

jwalits commented Feb 29, 2024

When multiple IdP's are setup in Moodle/Totara and an IdP initiated request comes in from the second configured IdP it fails producing an error like below:

SAML2 exception: Cannot retrieve metadata for IdP '<IdP URL>' because it isn't a valid IdP for this SP.

After doing some debugging/testing, it was traced down to this line of custom code in the simplesamlphp lib: https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/.extlib/simplesamlphp/modules/saml/src/Auth/Source/SP.php#L312

The data this for loops expects is in a different format now, thus never setting $this->idp to null and throwing the error below.

jwalits added a commit that referenced this issue Feb 29, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
Peterburnett pushed a commit that referenced this issue Feb 29, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
jwalits added a commit that referenced this issue Feb 29, 2024
[#801] fix issue with IdP initiated login after upgrade to v2.0.5 (#802)
jay-oswald pushed a commit that referenced this issue Nov 20, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
jay-oswald pushed a commit that referenced this issue Nov 28, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
gbarat87 pushed a commit that referenced this issue Dec 11, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
gbarat87 pushed a commit that referenced this issue Dec 13, 2024
* [#801] fix issue with IdP initiated login after upgrade to v2.0.5

* [#801] restore comment for searching purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant