PHP unit tests fail in 3.9 if run as a testsuite

[dmitriim]

Steps to replicate:

1. Get a vanilla 3.9
2. Pull auth_saml2 plugin code in.
3. php admin/tool/phpunit/cli/init.php
4. Run core tests ./vendor/bin/phpunit --stop-on-failure --testsuite core_testsuite
5. Get the failure

This happens because PHPMailer gets auto-loaded from auth_saml2 plugin and it has a different (higher) version to what's in core.

Time: 21.34 minutes, Memory: 297.00 MB

There was 1 failure:

1) core_moodlelib_testcase::test_email_to_user_attachment with data set "cachedir" ('/var/lib/sitedata/moodle-test/cache')
Failed asserting that 'This is a multi-part message in MIME format.\n
\n
--b1_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM\n
Content-Type: multipart/alternative;\n
 boundary="b2_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM"\n
\n
--b2_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM\n
Content-Type: text/plain; charset=UTF-8\n
Content-Transfer-Encoding: quoted-printable\n
\n
=0ATest attachment path=0A\n
--b2_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM\n
Content-Type: text/html; charset=UTF-8\n
Content-Transfer-Encoding: quoted-printable\n
\n
Test attachment path\n
\n
--b2_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM--\n
\n
--b1_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM\n
Content-Type: text/plain; name=hello.txt\n
Content-Transfer-Encoding: base64\n
Content-Disposition: attachment; filename=hello.txt\n
\n
SGVsbG8=\n
\n
--b1_NQnOschkfbWNggpTPMVlFmZmaXXR77vq99fKNsmqAEM--\n
' contains "Content-Type: text/plain; name="hello.txt"".

/var/www/project/moodle/lib/tests/moodlelib_test.php:111
/var/www/project/moodle/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "core_moodlelib_testcase" lib/tests/moodlelib_test.php

FAILURES!
Tests: 2069, Assertions: 39356, Failures: 1, Skipped: 2.

[Anupamatd]

Hi,

This PHP unit tests fail came again due to recent update simplesamlphp to 1.19.1 with below commit:
d0dfa3b

Thanks,
Anu

[dmitriim]

@Anupamatd this was the fix 1c40898

[Anupamatd]

Thank you @dmitriim - will try this 1c40898.
I thought this was the fix 6285e03

[dmitriim]

Oh. Maybe you are right. Or maybe both?

[Anupamatd]

Hey @dmitriim - This fix (6285e03) fixed issue in my local

Do i need to also remove composer files from compiled extlib/simplesamlphp (1c40898)?

[dmitriim]

I'd recommend it.

[Anupamatd]

Thank you @dmitriim - will remove that.

[Anupamatd]

Hey @dmitriim - Created a PR - #611
Please review and merge.
Thank you.