WR438262: Submission interface improvements #84
Conversation
sarahjcotton
force-pushed
the
WR438262-submission-interface-improvements
branch
from
e2110c6 to
e28826a
Compare
sarahjcotton
force-pushed
the
WR438262-submission-interface-improvements
branch
from
e28826a to
653d646
Compare
|
@danmarsden Would you mind reviewing this please? |
| $viewurl = "/view/view.php?id=" . $view['id']; | ||
| $anchor = $this->get_preview_url($view['title'], $viewurl, strip_tags($view['description'])); | ||
| $mform->addElement('radio', 'viewid', '', $anchor, 'v' . $view['id']); | ||
| if ($view['submissionoriginal'] == 0) { |
There was a problem hiding this comment.
What does $view['submissionoriginal'] == 0 mean? Maybe add a comment explaining it? Same below on line 500
| $currentpagesubmitted = $mform->createElement('static', 'currentsubmission', | ||
| get_string('currentsubmitted', 'assignsubmission_maharaws', 'page'), $view['displaytitle']); |
There was a problem hiding this comment.
Looks like this can can be abstracted to a method to avoid a code duplication. See pretty much same code at lines 506-507
There was a problem hiding this comment.
I've run out of time on this WR so can only do what's necessary to move it along I'm afraid.
| @@ -25,6 +25,7 @@ | |||
| $string['assign_submission_maharaws_name'] = 'Mahara Assignment submission (web services)'; | |||
| $string['assign_submission_maharaws_description'] = 'Mahara functions used in Mahara assignment submission plugin.<br />Publishing this service on a Moodle site has no effect. Subscribe to this service if you want to be able to use assignments with {$a}.<br />'; | |||
| $string['collectionsby'] = 'Collections by {$a}'; | |||
| $string['currentsubmitted'] = 'Current submitted {$a}'; | |||
There was a problem hiding this comment.
Probably need a version bump for this string to come up.
|
Hi @sarahjcotton |
sarahjcotton
force-pushed
the
WR438262-submission-interface-improvements
branch
from
653d646 to
51a82b6
Compare
|
Thanks @dmitriim hopefully this should be good to go now! |
Addresses #83
However, once the locked options are removed from the selection screen it makes it difficult for the student to see what's currently submitted as that is also locked, so I've added in a static element to display the currently selected item.
Previously the currently selected item would have been selected, but if the student tries to resubmit it instead of going back/canceling, an error occurs, so this also addresses that.
Submitted page
Submitted collection