Merge pull request #81 from sarahjcotton/WR438262-other-fixes

WR438262: Use empty instead of count to avoid errors when no content
catalyst · Jul 31, 2024 · 69ac1a6 · 69ac1a6
2 parents 21f9cbb + a5706aa
commit 69ac1a6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/locallib.php b/locallib.php
@@ -458,7 +458,7 @@ public function get_form_elements_for_user($submission, MoodleQuickForm $mform,
         $remotehost->name = $remotehost->sitename;
 
         // See if any of views are already in use, we will remove them from select.
-        if (count($viewids) || count($views['collections']['data'])) {
+        if (!empty($viewids) || !empty($views['collections']['data'])) {
             $mform->addElement(
                 'static',
                 '',
@@ -471,7 +471,7 @@ public function get_form_elements_for_user($submission, MoodleQuickForm $mform,
             $mform->setType('viewid', PARAM_ALPHANUM);
             $mform->setDefault('viewid', 'none');
 
-            if (count($views['data'])) {
+            if (!empty($views['data'])) {
                 $mform->addElement('static', '',
                     get_string('viewsby', 'assignsubmission_maharaws', $views['displayname'])
                 );
@@ -482,7 +482,7 @@ public function get_form_elements_for_user($submission, MoodleQuickForm $mform,
                     $mform->addElement('radio', 'viewid', '', $anchor, 'v' . $view['id']);
                 }
             }
-            if (count($views['collections']['data'])) {
+            if (!empty($views['collections']['data'])) {
                 $mform->addElement('static', 'collection_by',
                     get_string('collectionsby', 'assignsubmission_maharaws', $views['displayname'])
                 );