-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback pandas-1.5 #1945
Rollback pandas-1.5 #1945
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportBase: 82.8% // Head: 82.8% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1945 +/- ##
=====================================
Coverage 82.8% 82.8%
=====================================
Files 65 65
Lines 7436 7436
=====================================
+ Hits 6158 6159 +1
+ Misses 1278 1277 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The nightly build for this branch passed on a 32 GB machine and has a memory profile similar to the builds before upgrading to pandas 1.5. Memory profiles: Some potential pandas-1.5 bugs:
|
I'd be surprised if the downcasting solution wasn't reducing memory usage in the places where it's been applied. The blowup was happening because e.g. running I searched the codebase for any instance of Maybe there are other ways that one might try and invoke the same behavior without explicitly mentioning the data type? Should we run a memory profiler and see where it explodes? |
I'll profile the EIA ETL because its using 2x memory with pandas-1.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welp, it's annoying but I guess we should merge this into dev
to get the nightly builds working again and re-open #1901 until we've hunted down the memory issue, or it's been fixed upstream.
Since updating to pandas-1.5, our nightly builds have doubled in memory use. I'm opening this PR to test the memory use with pandas 1.4.x.