Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port make cooking oil unhealthy #731

Merged
merged 2 commits into from
Jul 31, 2021
Merged

Port make cooking oil unhealthy #731

merged 2 commits into from
Jul 31, 2021

Conversation

ZhamelSeh
Copy link
Contributor

Summary

SUMMARY: [Balance] "Make cooking oil unhealthy"

Purpose of change

Cooking oil doesn't have unhealthy value, which most players would assume to be true. Make it so. Our survivors should probably try to find a more befitting food source than drinking gallons of oil months on end.

Also, today I learned that, while olive oil is particularly good for you, vegetable oil is not:
https://www.jeffnobbs.com/posts/death-by-vegetable-oil-what-the-studies-say

Describe the solution

Make cooking oil unhealthy

Describe alternatives you've considered

N/A

Testing

Drink cooking oil in large batches and debug check our healthy stat

Additional context

Copied from origin PR: CleverRaven/Cataclysm-DDA#49758

@Coolthulhu Coolthulhu self-assigned this Jul 31, 2021
@Coolthulhu Coolthulhu merged commit f52d88f into cataclysmbnteam:upload Jul 31, 2021
@Coolthulhu
Copy link
Member

Though food healthiness isn't working properly at the moment.

@ZhamelSeh ZhamelSeh deleted the Port-make-cooking-oil-unhealthy branch August 1, 2021 05:45
@ZhamelSeh
Copy link
Contributor Author

Any idea(s) on why it isn't working?

@Coolthulhu
Copy link
Member

The update speed doesn't match one that is used in tests, so the tests - which say things are working right - don't match gameplay.
For it to start working as intended, number crunching and update of both real health update rate and tests is needed.

As far as I recall, health tests have comments explaining the discrepancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants