Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balance): make NV mutations passive #6056

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

Goredell
Copy link
Contributor

@Goredell Goredell commented Feb 6, 2025

Purpose of change (The Why)

to sum up - night vision mutations are currently togglable, while they don't do anything if u on/off them:

Describe the solution (The How)

Proposition is to make those passive, so those don't confuse players

Also as per @RoyalFox2140: "purely beneficial mutations have no right to be toggled on"

Describe alternatives you've considered

Make toggle effect actually do smth

Testing

Game is builing and starting, mutations are no longer togglable

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 6, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and load-tested to make sure that NV being passive didn't somehow break it, seems to work.

@chaosvolt chaosvolt merged commit 1d14ffe into cataclysmbnteam:main Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Night Vision Trait range doesn't add up to Night Vision range via Perception
2 participants