Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rabbit mutation to Mr_Lapin #6051

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Feb 5, 2025

Purpose of change (The Why)

When Rabbit Mutations were added to the game, they weren't added to the game's only Rabbit NPC

Describe the solution (The How)

I added them

Describe alternatives you've considered

Testing

image

Additional context

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 5, 2025
@Zlorthishen Zlorthishen changed the title Feat: Update Mr_Lapin feat: Update Mr_Lapin Feb 5, 2025
Copy link
Contributor

autofix-ci bot commented Feb 5, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Zlorthishen Zlorthishen marked this pull request as ready for review February 5, 2025 02:39
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bnuuy-bunny

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename the title to be more descriptive. "lapin update" is ambiguous.

@scarf005 scarf005 changed the title feat: Update Mr_Lapin feat: add missing rabbit mutation to Mr_Lapin Feb 5, 2025
@scarf005 scarf005 changed the title feat: add missing rabbit mutation to Mr_Lapin feat: add rabbit mutation to Mr_Lapin Feb 5, 2025
@chaosvolt chaosvolt merged commit eaeebbf into cataclysmbnteam:main Feb 5, 2025
11 of 14 checks passed
@Zlorthishen Zlorthishen deleted the Mr_Lapin_isnt_a_Rabbit branch February 8, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants