feat(balance, mods/MagicalNights): Buff legendary weapons, fix typo #6050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
The "legendary" weapons from Norse mythos were considered pretty crappy and not-epic by everyone, and I agree. Thus, I felt the need to buff these items to the status they deserve.
Also, in a previous PR (#6043) I used "steal" instead of "steel" in the orichalcum fire axe's new description, somehow, so I fixed that while I was in the file.
Describe the solution (The How)
to_hit
of the relevant weaponsDescribe alternatives you've considered
I don't want to deal with the migration and also that seems like a bad idea
I'm far more amicable to this idea, but I think the better solution is to just add the non-Norse weapons in addition to the Norse instead of replacing
Testing
Loaded in, confirmed the enchantments work appropriately
Additional context
Gram is probably kinda disappointing, but I wanted to keep it fairly mythos accurate.
Gungnir's effect is the best I can do without making it an item cast or making a flag like
NO_MISS
for melee attacks, with this solution making it so that if you hit once you hit every time afterwards basically.Checklist
Mandatory
closes #1234
in Summary of the PR so it can be closed automatically.main
so it won't cause conflict when updatingmain
branch later.