Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Debug spells from Magical Nights moved into Vanilla #6048

Merged

Conversation

RobbieNeko
Copy link
Collaborator

Purpose of change (The Why)

This way the Magical Nights folder can better avoid being in any future DDA spell effect ports, and anyone testing them with a debug spell can just load up any old world instead of needing a Magical Nights world. Additionally, this was the course of action recommended by Oren.

Describe the solution (The How)

Moves the file from data/mods/Magical_Nights/spells to data/json and also renames it for clarity's sake.

Describe alternatives you've considered

  • Create another in-repo mod for them
  • Put it in TEST_DATA
  • Just leave it be
  • Time-travel and put them in a future in-repo Arcana to mess with Chaosvolt

Testing

These are only obtainable via debug menu anyway, and renaming a json file shouldn't cause any issues.

Additional context

Also, we could probably do with an expansion of the debug spells covered in it / a restoration of some of the ones in previous PR's that went missing.

Checklist

Mandatory

There's probably more in here somewhere...
@github-actions github-actions bot added docs PRs releated to docs page JSON related to game datas in JSON format. labels Feb 4, 2025
@chaosvolt chaosvolt merged commit 24ff1c4 into cataclysmbnteam:main Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants