refactor: Debug spells from Magical Nights moved into Vanilla #6048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
This way the Magical Nights folder can better avoid being in any future DDA spell effect ports, and anyone testing them with a debug spell can just load up any old world instead of needing a Magical Nights world. Additionally, this was the course of action recommended by Oren.
Describe the solution (The How)
Moves the file from
data/mods/Magical_Nights/spells
todata/json
and also renames it for clarity's sake.Describe alternatives you've considered
Testing
These are only obtainable via debug menu anyway, and renaming a json file shouldn't cause any issues.
Additional context
Also, we could probably do with an expansion of the debug spells covered in it / a restoration of some of the ones in previous PR's that went missing.
Checklist
Mandatory
closes #1234
in Summary of the PR so it can be closed automatically.main
so it won't cause conflict when updatingmain
branch later.