Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix no hacksaw on metal bar window, closed doors block scent #6029

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Feb 1, 2025

Purpose of change (The Why)

We decided windows blocking scent was nice, this does the same for doors. This isn't ideal as we lack a scent map and proper tracking and granularity, but it's all or nothing so it's fine this way.

Also fixes one window with metal bars not being hacksawed

Describe the solution (The How)

Adds NO_SCENT to the doors that are closed and intact.

Adds hacksaw action to the one specific window

Describe alternatives you've considered

Better scent system overall.

Testing

Tests

Additional context

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 1, 2025
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two feels like a completely different subject imo, might be better to open separate PRs

@RoyalFox2140
Copy link
Collaborator Author

Why have a PR open for a single change? That bloats the feed

@scarf005
Copy link
Member

scarf005 commented Feb 1, 2025

bloats which feed? mixing multiple unrelated PRs makes it harder to organize and revert it later, and i don't think the pros outweigh the cons.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're both consistency updates to terrain and both changes seem fine to me, and only affects two files. While ideal practice would be to make them two separate PRs, I'm not gonna veto it just for being bundled. Especially since the hacksaw change is literally just one lilterrain update.

@chaosvolt chaosvolt merged commit ef10251 into cataclysmbnteam:main Feb 2, 2025
13 checks passed
@RoyalFox2140 RoyalFox2140 deleted the misc-fixes branch February 2, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants