feat(port): streams

[LyleSY]

Purpose of change (The Why)

More interesting wilderness maps, enabling more interesting monster spawns. Required for DinoMod monster spawn port.

Describe the solution (The How)

A stream. Associated monstergroup is entirely rebuilt due to code and content differences.
Ported from:
CleverRaven/Cataclysm-DDA#71008
...which ports mod content originally created here:
CleverRaven/Cataclysm-DDA#67065

Removes content and features that are not present or supported in BN
Some content tweaks to better match BN standards based on feedback

Describe alternatives you've considered

N/A

Testing

Game loads no errors. Streams spawn as expected and look right

Additional context

Part of a larger effort to rebalance DinoMod spawns. Also handy for any future innawood work
Credit to @SandwichPie and @Light-Wave for the original JSON work

Checklist

Mandatory

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax like closes #1234 in Summary of the PR so it can be closed automatically.
• I've committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

Optional

• This PR ports commits from DDA or other cataclysm forks.
  • I have attributed original authors in the commit messages adding Co-Authored-By in the commit message.
  • I have linked the URL of original PR(s) in the description.

[scarf005]

"t_region_tree_forest"
([slow] ~starting_items)=> Terminated: ::error file=data/json/overmap/overmap_terrain/overmap_terrain_stream.json,line=10,col=39::invalid overmap terrain flag: "REQUIRES_PREDECESSOR"
([slow] ~starting_items)=> 
([slow] ~starting_items)=>     "color": "light_blue",
([slow] ~starting_items)=>     "vision_levels": "blends_till_details",
([slow] ~starting_items)=>     "flags": [ "REQUIRES_PREDECESSOR" ]
([slow] ~starting_items)=>                                       ^
([slow] ~starting_items)=> 
([slow] ~starting_items)=>   }
([slow] ~starting_items)=> ]
([slow] ~starting_items)=> 
([slow] ~starting_items)=> Make sure that you're in the correct working directory and your data isn't corrupted.
test exited with code 1

REQUIRES_PREDECESSOR seems to be an DDA-only flag and thus is failing the tests

[OrenAudeles]

It looks like you're lifting the linked PR contents wholesale with minimal modification. You need to add the original PR authors as co-authors, and fill out some of the Optional (now required) parts of the checklist

- [ ] This PR ports commits from DDA or other cataclysm forks.
  - [ ] I have attributed original authors in the commit messages adding [`Co-Authored-By`](https://docs.github.com/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors) in the commit message.
  - [ ] I have linked the URL of original PR(s) in the description.

I'd also like a better description than Ports mapgen content under Purpose of Change since it's meant to answer the question Why should we merge this PR?

[Light-Wave]

Credit to @SandwichPie for most of the original JSON work

[scarf005]

Credit to @SandwichPie for most of the original JSON work

please read:

  - [ ] I have attributed original authors in the commit messages adding [`Co-Authored-By`](https://docs.github.com/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors) in the commit message.

[LyleSY]

It looks like we aren't throwing errors anymore, which is exciting to see. I don't have an email for @SandwichPie or a way to get in contact with them. Is it adequate to link the original PR and author?

[scarf005]

I don't have an email for @SandwichPie or a way to get in contact with them. Is it adequate to link the original PR and author?

their email is sandwichpie007@gmail.com (from https://github.com/SandwichPie/SandwichPie.github.io/commit/909889a7b9638b7fa52d1a7c958c7ab0f647205a.patch). see https://wizardsourcer.com/simple-way-to-find-github-user-emails/ for details.

[chaosvolt]

1. Compiled and load-tested.
2. Revealed map, could encounter streams.
3. Went to a stream and uh...

Honestly it looks goofy as hell and this doesn't even show how it winds all over the map screen across open fields, like:

Bare minimum, you need to sanity-check the item spawns on it, this is with default item spawn rate. If you can also sanity-check how long streams are that'd be ideal too because this one stream winds south from negative 143 all the way to -47 and then BACK UP as far as -101.

Both also ended just running into a road, and evidently rely on being a non-unique mandatory overmap special? I do like this implementation in the slightest to be honest, it reeks of hackery.

[chaosvolt]

Unless I can figure out what property controls the max size of streams or some way to fix it liking to ram into roads, can't think of any other improvements to this.

[LyleSY]

Based on my incredibly bad understanding of mapgen, it should be possible to create a stream bridge in the same way we have river bridges. No one has done this in DDA yet (this came from innawood which has no roads anyway). I don't know that there is a stream length cap either in mapgen.

[chaosvolt]

I know there's SOME sort of size setting for mutable mapgen but I've yet to really dick around with how it works, so hmm.