Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port,UI): Allow Bionics to be hidden #5855

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

Zlorthishen
Copy link
Contributor

Checklist

Required

Purpose of change

allows bionics to be hidden

Describe the solution

ports dda PR

Describe alternatives you've considered

Testing

Additional context

Screenshot 2024-12-30 184700

port of CleverRaven/Cataclysm-DDA#65243

Co-Authored-By: Rewryte <129854247+rewryte@users.noreply.github.com>
@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Dec 31, 2024
@Zlorthishen Zlorthishen changed the title feat(port): feat(port): Allow Bionics to be hidden Dec 31, 2024
@Zlorthishen Zlorthishen marked this pull request as ready for review December 31, 2024 00:50
Copy link
Contributor

autofix-ci bot commented Dec 31, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 changed the title feat(port): Allow Bionics to be hidden feat(port,UI): Allow Bionics to be hidden Dec 31, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only playtesting needed

Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

Today I learned passive CBM's have their own menu

@scarf005
Copy link
Member

i'm so excitied with this change i want to release a new one today

Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on my machine and I can hide my alloy plating
image
image

@RoyalFox2140 RoyalFox2140 merged commit 8dc9c31 into cataclysmbnteam:main Dec 31, 2024
16 checks passed
@Zlorthishen Zlorthishen deleted the hide-bionic-sprites branch December 31, 2024 02:52
@Zlorthishen Zlorthishen restored the hide-bionic-sprites branch December 31, 2024 03:27
@Zlorthishen Zlorthishen deleted the hide-bionic-sprites branch December 31, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants