Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up usage of bread and condiment crafting quality #2636

Merged

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Balance "Make more use of new bread_sandwich, condiment, and bone_sturdy crafting requirements"

Purpose of change

Follow-up to #2369, implementing some uses of the crafting requirements added to vanilla.

Describe the solution

  1. Made use of condiment crafting requirement, mainly for sandwiches/burgers calling for a wide variety of options for sauce. Left a few specialized recipes like oddball uses for mustard, some hot dog recipes, salads and the like untouched for now.
  2. Updated bread_sandwich crafting requirement to include garlic bread. Also added cornbread to it since I don't think we have any existing specialized wheat-free sandwich recipes in vanilla at present, so bread_sandwich_wheat_free might not see much use right now.
  3. Made use of bread_sandwich requirement for all fitting sandwich-type recipes.
  4. Phased in usage of bone_sturdy in relevant recipes, excluding recipes that also allow tainted bone for now.
    . Misc: Also added crackers to bird food because I spotted it and noticed hardtack was an option.

Haven't yet started tinkering with using fabric_leather_fur_hide or tailoring_leather_patchwork, the latter is probably pointless since we can use the former plus filament as warranted, but the former meanwhile overlaps with #2138 defining fabric_hides_proper for relevant recipes. I'll probably update my PR and switch it to this new requirement.

Describe alternatives you've considered

  1. Hardtack sandwiches too someday? Dunno. Probably a bit more extreme than just cracker sandwiches.
  2. Porting over whatever PR added wheat-free bread stuff?
  3. Not adding the crafting requirement to bone awls because those are eventually going to go the way of the other tailoring fluff.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Also eyeballed to make sure I didn't accidentally change any numbers in my infinite copy-pasting.

Additional context

https://www.youtube.com/watch?v=F6hC4qQbDzI

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Apr 13, 2023
@Firestorm01X2 Firestorm01X2 merged commit c9bb267 into cataclysmbnteam:upload Apr 30, 2023
@chaosvolt chaosvolt deleted the welcome-to-the-bread-bank branch April 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants