issue_raised_when_creating_a_react_project #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casweeney
approved these changes
Aug 20, 2024
casweeney
approved these changes
Aug 20, 2024
| match create_react_app(dir.dir_name.clone()) { | ||
| ScaffoldSubCommand::React(dir) => { | ||
| let result = match collect_arguement_from_the_terminal().trim() { | ||
| "j" => create_react_app(dir.dir_name.clone()), |
There was a problem hiding this comment.
The create_react_app() function returns a Result enum, you will have to have each variant
| ScaffoldSubCommand::React(dir) => { | ||
| let result = match collect_arguement_from_the_terminal().trim() { | ||
| "j" => create_react_app(dir.dir_name.clone()), | ||
| "t" => create_react_app_with_typescript(dir.dir_name.clone()), |
There was a problem hiding this comment.
Similarly the create_react_app_with_typescript() returns a Result enum, handle all variants.
| @@ -248,6 +243,18 @@ pub fn resolve(args: ClapperArgs) -> Result<(), Box<dyn Error>> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn collect_arguement_from_the_terminal() -> String { | |||
There was a problem hiding this comment.
There is already an existing pattern of getting command line inputs, don't reinvent the wheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i implemented a support so as to reduce the verbosity when creating a react project...