feat: support granular aggressive mode config #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladklokun
force-pushed
the
feat-support-granular-aggressive-mode-config
branch
from
b07ca31 to
83e6dd1
Compare
vladklokun
changed the title
pijusn-cast
approved these changes
Mar 3, 2025
furkhat
reviewed
Mar 3, 2025
Comment on lines
-53
to
+56
| "ignoreLocalPersistentVolumes": true | ||
| "ignoreLocalPersistentVolumes": true, | ||
| "ignoreProblemJobPods": true, | ||
| "ignoreProblemRemovalDisabledPods": true, | ||
| "ignoreProblemPodsWithoutController": true |
There was a problem hiding this comment.
could you fix indentation here?
There was a problem hiding this comment.
I’ll make the changes you've suggested in a separate PR, since this one has already been merged. Sounds fair?
Comment on lines
45
to
+49
| resource.TestCheckResourceAttr("castai_rebalancing_schedule.test", "launch_configuration.0.aggressive_mode", "true"), | ||
| resource.TestCheckResourceAttr("castai_rebalancing_schedule.test", "launch_configuration.0.aggressive_mode_config.0.ignore_local_persistent_volumes", "true"), | ||
| resource.TestCheckResourceAttr("castai_rebalancing_schedule.test", "launch_configuration.0.aggressive_mode_config.0.ignore_problem_job_pods", "true"), | ||
| resource.TestCheckResourceAttr("castai_rebalancing_schedule.test", "launch_configuration.0.aggressive_mode_config.0.ignore_problem_removal_disabled_pods", "true"), | ||
| resource.TestCheckResourceAttr("castai_rebalancing_schedule.test", "launch_configuration.0.aggressive_mode_config.0.ignore_problem_pods_without_controller", "true"), |
There was a problem hiding this comment.
Could you move ImportState test cases to the end? That way they will test new fields you added plus verify that after import the terraform plan has empty output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an updated granular aggressive mode config in scheduled rebalancing. We intend to replace the legacy bool-based
aggressiveModeflag by this config.