feat: add woop apply threshold strategy to tf scaling policy #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UOndro
requested review from
jansyk13 and
mszostok
and removed request for
a team and
jansyk13
mszostok
reviewed
Jan 14, 2025
UndeadRat22
reviewed
Jan 15, 2025
mszostok
reviewed
Jan 16, 2025
| @@ -567,13 +680,37 @@ func toWorkloadScalingPoliciesMap(p sdk.WorkloadoptimizationV1ResourcePolicies) | |||
| m[FieldLimitStrategy] = []map[string]any{limit} | |||
| } | |||
|
|
|||
| if v, ok := previousCfg["apply_threshold"].(float64); ok && v > 0 { | |||
There was a problem hiding this comment.
nit I would extract that into a func similar to what you did with resolveApplyThresholdStrategy. Then, place both functions close to each other and include a "business" comment explaining why it’s done this way, or just add a link to a gh comments, so even after N months, we’ll still be able to quickly understand “what the hell..” 😄
…oth applyThreshold and Strategy is missing
mszostok
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.