Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_package handle Key::Hash #5051

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Make get_package handle Key::Hash #5051

merged 3 commits into from
Jan 3, 2025

Conversation

darthsiroftardis
Copy link
Contributor

CHANGELOG:

  • Amend get_package on the effect builder to take a package addr and handle retrieving both contract packages and packages.

Closes #5050

@darthsiroftardis darthsiroftardis self-assigned this Jan 3, 2025
EdHastingsCasperAssociation
EdHastingsCasperAssociation approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming comments are addressed

@darthsiroftardis
Copy link
Contributor Author

bors r+

@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit 2178ad3 into casper-network:dev Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdHastingsCasperAssociation EdHastingsCasperAssociation EdHastingsCasperAssociation approved these changes

Assignees

@darthsiroftardis darthsiroftardis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Error when calling a contract using contract package hash
2 participants
@darthsiroftardis @EdHastingsCasperAssociation