Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix flake for prettier checks #185

Closed
wants to merge 2 commits into from

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Nov 1, 2024

just for you @callebtc

@thesimplekid thesimplekid changed the title Nix Wanna see my nix config :) Nov 1, 2024
@thesimplekid thesimplekid changed the title Wanna see my nix config :) Add nix flake for prettier checks Nov 1, 2024
@callebtc
Copy link
Contributor

callebtc commented Nov 4, 2024

why do we need this unsolicited nix config flash again?

@callebtc
Copy link
Contributor

callebtc commented Nov 4, 2024

visits spec repo, sees this:
image

@thesimplekid
Copy link
Collaborator Author

why do we need this unsolicited nix config flash again?

This would be useful to me as I don't have prettier installed globally to run the linting check, and it would be easier for me (and others on nix) to have a dev flake defined in the repo to drop into then creating a custom dev shell each time. However, I do realize this is likely an issue for only me so feel free to close.

Changing the CI only has the benefit since there is a flake defined it ensures what is run locally is run in CI, though in such a simply CI likely no real benefit.

@prusnak
Copy link
Collaborator

prusnak commented Nov 4, 2024

Closing then.

@prusnak prusnak closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants