Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thai translation #346

Merged
merged 4 commits into from
May 13, 2024
Merged

Add Thai translation #346

merged 4 commits into from
May 13, 2024

Conversation

vazw
Copy link
Contributor

@vazw vazw commented May 10, 2024

Added translation th.json to assets/translations

KKA11010
KKA11010 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the translation (using chatGPT) and they seem to be accurate and effectively conveys the intended meaning. Thank you for the PR! 🥇

KKA11010
KKA11010 requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vazw There are some missing translations. Please see the logs of the following workflow

@vazw
Copy link
Contributor Author

vazw commented May 13, 2024

@vazw There are some missing translations. Please see the logs of the following workflow

Alright I'll Re-check it again and made the new commit.

@vazw vazw closed this May 13, 2024
@vazw
Copy link
Contributor Author

vazw commented May 13, 2024

Here Added Missing texts and tested. actions

@vazw vazw reopened this May 13, 2024
KKA11010
KKA11010 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@KKA11010 KKA11010 merged commit 6aa1821 into cashubtc:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKA11010 KKA11010 KKA11010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vazw @KKA11010