-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review #141
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 15.32% 15.20% -0.12%
==========================================
Files 137 139 +2
Lines 4345 4445 +100
Branches 1172 1205 +33
==========================================
+ Hits 666 676 +10
- Misses 3600 3686 +86
- Partials 79 83 +4
☔ View full report in Codecov by Sentry. |
@KKA11010 Is the intent to display the onboarding screens before prompting the user for their pin? For what it's worth, I believe it's best to present them before asking for the pin. |
Ok I did not think much about it but it sounds good to show them before asking for pin. 👍 |
done |
Fixes #126
Fixes #130
Fixes #131
Fixes #132
Fixes #133
Fixes #134
Fixes #128
Fixes #143
Fixes #135
Fixes #138
@swedishfrenchpress, kindly execute the branch and inform me about the resolution status of the mentioned issues based on your review.