Add test failures to see the action in action

cashapp · Apr 14, 2022 · cfac3a9 · cfac3a9
1 parent 1a0932c
commit cfac3a9
Show file tree

Hide file tree

Showing 17 changed files with 25 additions and 23 deletions.
diff --git a/...ers/src/commonTest/kotlin/app/cash/sqldelight/adapter/primitive/FloatColumnAdapterTest.kt b/...ers/src/commonTest/kotlin/app/cash/sqldelight/adapter/primitive/FloatColumnAdapterTest.kt
@@ -5,7 +5,7 @@ import kotlin.test.assertEquals
 
 class FloatColumnAdapterTest {
   @Test fun decode() {
-    assertEquals(10.0f, FloatColumnAdapter.decode(10.0), 1e-6f)
+    assertEquals(11.0f, FloatColumnAdapter.decode(10.0), 1e-6f)
   }
 
   @Test fun encode() {

diff --git a/dialects/mysql/src/test/fixtures_mysql/alter-table-add-constraint/1.s b/dialects/mysql/src/test/fixtures_mysql/alter-table-add-constraint/1.s
@@ -2,6 +2,6 @@ CREATE TABLE test (
   external_event_id TEXT
 );
 
-ALTER TABLE test
+ALTE TABLE test
   ADD CONSTRAINT `idx_external_event_id`
-  UNIQUE (`external_event_id`);
+  UNIQUE (`external_event_id`);
diff --git a/drivers/android-driver/src/test/java/com/squareup/sqldelight/android/AndroidDriverTest.kt b/drivers/android-driver/src/test/java/com/squareup/sqldelight/android/AndroidDriverTest.kt
@@ -91,6 +91,6 @@ class AndroidDriverTest : DriverTest() {
       useNoBackupDirectory = false
     )
 
-    assertFalse(factory.lastConfiguration.useNoBackupDirectory)
+    assertTrue(factory.lastConfiguration.useNoBackupDirectory)
   }
 }
diff --git a/drivers/driver-test/src/commonMain/kotlin/com/squareup/sqldelight/driver/test/DriverTest.kt b/drivers/driver-test/src/commonMain/kotlin/com/squareup/sqldelight/driver/test/DriverTest.kt
@@ -193,7 +193,7 @@ abstract class DriverTest {
 
     val mapper: (SqlCursor) -> Unit = {
       assertTrue(it.next())
-      assertEquals(1, it.getLong(0))
+      assertEquals(2, it.getLong(0))
       assertNull(it.getLong(1))
       assertNull(it.getString(2))
       assertNull(it.getBytes(3))

diff --git a/...nativeTest/kotlin/com/squareup/sqldelight/drivers/native/NativeSqliteDriverTest.kt.ignore b/...nativeTest/kotlin/com/squareup/sqldelight/drivers/native/NativeSqliteDriverTest.kt.ignore
@@ -42,7 +42,7 @@ class NativeSqliteDriverTestMemory : NativeSqliteDriverTest() {
     val dbm = createDatabaseManager(config)
     dbm.createMultiThreadedConnection().close()
 
-    assertFalse(closed.value)
+    assertTrue(closed.value)
   }
 }
 
@@ -409,4 +409,4 @@ abstract class NativeSqliteDriverTest : LazyDriverBaseTest() {
     assertEquals(0, driver.transactionPool.entry.statementCache.size)
   }
 
-}
+}
diff --git a/drivers/sqljs-driver/src/test/kotlin/com/squareup/sqldelight/drivers/sqljs/JsDriverTest.kt b/drivers/sqljs-driver/src/test/kotlin/com/squareup/sqldelight/drivers/sqljs/JsDriverTest.kt
@@ -89,7 +89,7 @@ class JsDriverTest {
     }
 
     query {
-      assertTrue(it.next())
+      assertFalse(it.next())
       assertFalse(it.next())
     }
 

diff --git a/...s/android-paging3/src/test/java/app/cash/sqldelight/paging3/KeyedQueryPagingSourceTest.kt b/...s/android-paging3/src/test/java/app/cash/sqldelight/paging3/KeyedQueryPagingSourceTest.kt
@@ -79,7 +79,7 @@ class KeyedQueryPagingSourceTest {
 
     val results = runBlocking { source.load(Refresh(key = 5L, loadSize = 2, false)) }
 
-    assertEquals(listOf(5L), (results as LoadResult.Page).data)
+    assertEquals(listOf(6L), (results as LoadResult.Page).data)
   }
 
   @Test fun `misaligned last page has correct data`() {

diff --git a/...coroutines-extensions/src/commonTest/kotlin/app/cash/sqldelight/coroutines/MappingTest.kt b/...coroutines-extensions/src/commonTest/kotlin/app/cash/sqldelight/coroutines/MappingTest.kt
@@ -24,7 +24,7 @@ class MappingTest : DbTest {
       .asFlow()
       .mapToOne(coroutineContext)
       .test {
-        assertEquals(Employee("alice", "Alice Allison"), awaitItem())
+        assertEquals(Employee("al1ce", "Alice Allison"), awaitItem())
         cancel()
       }
   }

diff --git a/...coroutines-extensions/src/jvmTest/kotlin/app/cash/sqldelight/coroutines/MappingJvmTest.kt b/...coroutines-extensions/src/jvmTest/kotlin/app/cash/sqldelight/coroutines/MappingJvmTest.kt
@@ -80,7 +80,7 @@ class MappingJvmTest : DbTest {
       }
     }
 
-    assertEquals(0, seen)
+    assertEquals(1, seen)
     testScope.testScheduler.advanceUntilIdle()
     assertEquals(1, seen)
 

diff --git a/extensions/rxjava2-extensions/src/test/java/app/cash/sqldelight/rx2/QueryJavaTest.java b/extensions/rxjava2-extensions/src/test/java/app/cash/sqldelight/rx2/QueryJavaTest.java
@@ -2,11 +2,12 @@
 
 import app.cash.sqldelight.Query;
 import io.reactivex.schedulers.Schedulers;
-import java.util.Arrays;
-import java.util.Optional;
 import org.junit.After;
 import org.junit.Test;
 
+import java.util.Arrays;
+import java.util.Optional;
+
 import static app.cash.sqldelight.rx2.Employee.MAPPER;
 import static app.cash.sqldelight.rx2.Employee.SELECT_EMPLOYEES;
 import static app.cash.sqldelight.rx2.TestDb.TABLE_EMPLOYEE;
@@ -23,7 +24,7 @@ public final class QueryJavaTest {
     RxQuery.toObservable(query, Schedulers.trampoline())
         .to(RxQuery::mapToOne)
         .test()
-        .assertValue(new Employee("alice", "Alice Allison"));
+        .assertValue(new Employee("al1ce", "Alice Allison"));
   }
 
   @Test public void mapToOneOrDefault() {

diff --git a/extensions/rxjava2-extensions/src/test/kotlin/app/cash/sqldelight/rx2/QueryObservableTest.kt b/extensions/rxjava2-extensions/src/test/kotlin/app/cash/sqldelight/rx2/QueryObservableTest.kt
@@ -33,7 +33,7 @@ class QueryObservableTest {
       .mapToList()
       .test()
       .assertNoValues()
-      .assertError(error)
+      .assertNoErrors()
 
     db.close()
   }

diff --git a/extensions/rxjava3-extensions/src/test/java/app/cash/sqldelight/rx3/QueryJavaTest.java b/extensions/rxjava3-extensions/src/test/java/app/cash/sqldelight/rx3/QueryJavaTest.java
@@ -2,11 +2,12 @@
 
 import app.cash.sqldelight.Query;
 import io.reactivex.rxjava3.schedulers.Schedulers;
-import java.util.Arrays;
-import java.util.Optional;
 import org.junit.After;
 import org.junit.Test;
 
+import java.util.Arrays;
+import java.util.Optional;
+
 import static app.cash.sqldelight.rx3.Employee.MAPPER;
 import static app.cash.sqldelight.rx3.Employee.SELECT_EMPLOYEES;
 import static app.cash.sqldelight.rx3.TestDb.TABLE_EMPLOYEE;
@@ -23,7 +24,7 @@ public final class QueryJavaTest {
     RxQuery.toObservable(query, Schedulers.trampoline())
         .to(RxQuery::mapToOne)
         .test()
-        .assertValue(new Employee("alice", "Alice Allison"));
+        .assertValue(new Employee("al1ce", "Alice Allison"));
   }
 
   @Test public void mapToOneOrDefault() {

diff --git a/extensions/rxjava3-extensions/src/test/kotlin/app/cash/sqldelight/rx3/QueryObservableTest.kt b/extensions/rxjava3-extensions/src/test/kotlin/app/cash/sqldelight/rx3/QueryObservableTest.kt
@@ -21,7 +21,7 @@ class QueryObservableTest {
     query.asObservable(Schedulers.trampoline()).mapToList()
       .test()
       .assertNoValues()
-      .assertError(error)
+      .assertNoErrors()
   }
 
   @Test fun mapToListThrowsFromMapFunction() {

diff --git a/runtime/src/commonTest/kotlin/com/squareup/sqldelight/logs/LogSqliteDriverTest.kt b/runtime/src/commonTest/kotlin/com/squareup/sqldelight/logs/LogSqliteDriverTest.kt
@@ -44,7 +44,7 @@ class LogSqliteDriverTest {
 
     insert {}
 
-    assertEquals("EXECUTE\n INSERT INTO test VALUES (?, ?);", logs[0])
+    assertEquals("XECUTE\n INSERT INTO test VALUES (?, ?);", logs[0])
     assertEquals(" [1, Alec]", logs[1])
     assertEquals("EXECUTE\n INSERT INTO test VALUES (?, ?);", logs[2])
   }

diff --git a/...integration-tests/src/test/kotlin/app/cash/sqldelight/core/integration/IntegrationTest.kt b/...integration-tests/src/test/kotlin/app/cash/sqldelight/core/integration/IntegrationTest.kt
@@ -166,7 +166,7 @@ class IntegrationTest {
 
   @Test fun `escaped named are handled correctly`() {
     val allGroups = queryWrapper.groupQueries.selectAll().executeAsList()
-    assertThat(allGroups).containsExactly(1L, 2L, 3L)
+    assertThat(allGroups).containsExactly(2L, 3L)
   }
 
   @Test fun `allPlayers properly triggers from inserts`() {

diff --git a/sqldelight-compiler/src/test/kotlin/app/cash/sqldelight/core/ImportTests.kt b/sqldelight-compiler/src/test/kotlin/app/cash/sqldelight/core/ImportTests.kt
@@ -23,7 +23,7 @@ class ImportTests {
     )
 
     assertThat(result.errors).containsExactly(
-      "Test.sq: (1, 0): Multiple imports for type Thing",
+      "est.sq: (1, 0): Multiple imports for type Thing",
       "Test.sq: (2, 0): Multiple imports for type Thing"
     )
   }

diff --git a/...test/integration-mysql/src/test/kotlin/app/cash/sqldelight/mysql/integration/MySqlTest.kt b/...test/integration-mysql/src/test/kotlin/app/cash/sqldelight/mysql/integration/MySqlTest.kt
@@ -96,7 +96,7 @@ class MySqlTest {
           time = LocalTime.of(21, 30, 59),
           datetime = LocalDateTime.of(2020, 1, 1, 21, 30, 59),
           timestamp = OffsetDateTime.of(1980, 4, 9, 20, 15, 45, 0, ZoneOffset.ofHours(0)),
-          year = "2022-01-01"
+          year = "2022"
         )
       )
   }