Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example and readme with kong and hcl #123

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

mightyguava
Copy link
Contributor

No description provided.

@mightyguava mightyguava requested a review from purplefox August 27, 2021 18:26
@purplefox
Copy link
Collaborator

Thanks. Can you also update the main so it doesn't attempt to log errors using logrus? https://github.com/squareup/pranadb/blob/main/cmd/pranadb/main.go#L23
This causes the crash on my machine, as logrus isn't initialised at this point.
Replacing with fmt.println logging will show the real error.

@mightyguava
Copy link
Contributor Author

mightyguava commented Aug 27, 2021

If you've got a stack trace can you paste it? Logrus is initialized by default. The log.Configure call customizes the configuration. I don't expect it to crash.

@mightyguava mightyguava merged commit 859554e into main Aug 27, 2021
@mightyguava mightyguava deleted the yunchi/config branch August 27, 2021 18:47
@purplefox
Copy link
Collaborator

Here is the stack trace. It happens with the first call to logrus, here is an example:

runtime.systemstack_switch at asm_amd64.s:350
runtime.libcCall at sys_libc.go:49
syscall.syscall at sys_darwin.go:23
:1
golang.org/x/sys/unix.ioctl at zsyscall_darwin_amd64.go:690
golang.org/x/sys/unix.IoctlGetTermios at ioctl.go:73
github.com/sirupsen/logrus.isTerminal at terminal_check_bsd.go:11
github.com/sirupsen/logrus.checkIfTerminal at terminal_check_notappengine.go:13
github.com/sirupsen/logrus.(*TextFormatter).init at text_formatter.go:106
github.com/sirupsen/logrus.(*TextFormatter).Format.func1 at text_formatter.go:196
sync.(*Once).doSlow at once.go:68
sync.(*Once).Do at once.go:59
github.com/sirupsen/logrus.(*TextFormatter).Format at text_formatter.go:196
github.com/sirupsen/logrus.(*Entry).write at entry.go:279
github.com/sirupsen/logrus.(*Entry).log at entry.go:251
github.com/sirupsen/logrus.(*Entry).Log at entry.go:293
github.com/sirupsen/logrus.(*Entry).Logf at entry.go:338
github.com/sirupsen/logrus.(*Logger).Logf at logger.go:151
github.com/sirupsen/logrus.(*Logger).Infof at logger.go:165
github.com/sirupsen/logrus.Infof at exported.go:199
github.com/squareup/pranadb/cluster/dragon.(*Dragon).Start at dragon.go:275
github.com/squareup/pranadb/server.(*Server).Start at server.go:122
main.(*runner).run at main.go:53
main.main at main.go:22
runtime.main at proc.go:255
runtime.goexit at asm_amd64.s:1581
 - Async Stack Trace
<autogenerated>:2

@purplefox
Copy link
Collaborator

purplefox commented Aug 28, 2021

So basically I am unable to run Prana at all right now, or even run tests in the IDE.
Submitted an issue here sirupsen/logrus#1275
If we can't find a solution quickly we will need to roll back logrus to unblock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants