Add an injected assemblyValidation closure for ModuleAssembler #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfol
force-pushed
the
bradfol/assembly-validation
branch
2 times, most recently
from
b0649f4 to
45c3487
Compare
skorulis-ap
reviewed
Oct 25, 2023
| // if the root assembly is targeting an incorrect resolver. | ||
| if let assemblyValidation { | ||
| do { | ||
| try assemblyValidation(from) |
There was a problem hiding this comment.
Should this check resolved instead of from as that is the type that will actually be used.
There was a problem hiding this comment.
Ah good catch I'll update
This will allow ScopedModuleAssembler to inject its validation rather than performing it at the very end.
bradfol
force-pushed
the
bradfol/assembly-validation
branch
from
45c3487 to
59c0d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow ScopedModuleAssembler to inject its validation rather than performing it at the very end.