Mark generated files as readonly #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszumski
reviewed
Oct 3, 2023
| let result = fileManager.createFile( | ||
| atPath: path, | ||
| contents: data, | ||
| attributes: [.posixPermissions: 0777] |
There was a problem hiding this comment.
Isn't 777 rwxrwxrwx? Do we want 555 instead for r-xr-xr-x?
There was a problem hiding this comment.
Octal to decimal conversion issue. I took it from an example that is working accidentally because it's a decimal number. Changed to 0o444 since I don't need execution anyway. Thanks for catching that.
skorulis-ap
force-pushed
the
skorulis/read-only
branch
from
bdf4cc7 to
ca80c02
Compare
jszumski
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are marked
// Do not edit directly!so setting them as readonly so Xcode will prompt to unlock the files.I used the example app to test that the files were generated correctly. Originally I marked the file as readonly as a separate operation which prevented the next
data.writefrom succeeding.