Handle module dependencies containing additional assemblies #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/additional-assemblies
branch
2 times, most recently
from
57f0358 to
2843246
Compare
bradfol
reviewed
Aug 28, 2023
| @Argument(help: """ | ||
| An array of string arguments for the name of each module dependency. | ||
| If none are provided a file will still be written to the outputPath. | ||
| If the module name ends in "Assembly" it will be treated as an additional assembly. |
There was a problem hiding this comment.
This seems like it also treats some dependency module names as additional dependencies?
bradfol
approved these changes
Aug 28, 2023
skorulis-ap
force-pushed
the
skorulis/additional-assemblies
branch
from
2843246 to
3f22a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to write a handler for additional module assemblies in cash-ios and hit the issue that the codegen treats every module as needing to be imported which is not true to modules which contains multiple assemblies.
I've allowed extra assemblies to be provided in either the list of modules or as a separate parameter. With the current cash-ios setup it's more complex to separate the modules and additional assemblies so this helps with that.
This should be re evaluated after fully migrating to bazel.