Add knit directive to handle types marked with @_spi #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfol
approved these changes
Aug 9, 2024
|
|
||
| // Only 1 SPI is supported, the second will overwrite the first | ||
| XCTAssertEqual( | ||
| try parse("// @knit @_spi(First) @_spi(Second)"), |
There was a problem hiding this comment.
Maybe we should produce an IDE error here
skorulis-ap
force-pushed
the
skorulis/spi
branch
from
c1a7811 to
5dc7b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle the case where a type is public with an
@_spimodifier. The generated resolver needs to also be marked with the same@_spimodifier. I used knit directives to supply this information as the parser doesn't know about the original type.This is a fairly rare case that happened to come up ideally we should support it.
Example error when trying to use
@_spi(Testing) protocol MySPITypeinside DI: