Add support for registering factories on the main thread #174
Conversation
| // thread using the knit generated resolver. If that call is not made on the main | ||
| // thread then a crash will occur. | ||
| @discardableResult | ||
| public func register<Service>( |
There was a problem hiding this comment.
I've only added a single register function for now. I'll setup an ERB to generate them all in a future PR
skorulis-ap
force-pushed
the
skorulis/main-actor
branch
from
f491f3a to
82a60c7
Compare
| .macOS(.v13), | ||
| .macOS(.v14), |
There was a problem hiding this comment.
It might be somewhat nice to support back one version of macOS, was there an API you needed?
There was a problem hiding this comment.
Yep error: 'assumeIsolated(_:file:line:)' is only available in macOS 14.0 or newer. Technically we don't actually use that in the knit code, it's part of the additions that are used by the app but due to the way the package is setup it will fail the build.
There was a problem hiding this comment.
If we move the register functions into Swinject then we can drop back down.
There was a problem hiding this comment.
Ok yeah let's bump the min platform version 👍
| public func register<Service>( | ||
| _ serviceType: Service.Type, | ||
| name: String? = nil, | ||
| factory: @escaping @MainActor (Resolver) -> Service |
There was a problem hiding this comment.
When introducing this override will the Swift compiler always match closures without the @MainActor attribute to the Swinject method?
There was a problem hiding this comment.
With adding @MainActor the compiler will pick the default one and then fail. I can't find any way to have a @MainActor function called without adding @MainActor to the closure signature. Which is good because it is always there for the parser to identify.
skorulis-ap
force-pushed
the
skorulis/main-actor
branch
5 times, most recently
from
3326444 to
16be759
Compare
skorulis-ap
force-pushed
the
skorulis/main-actor
branch
from
16be759 to
8d3b336
Compare
This allows
container.register(ServiceA.self) { @MainActor in ServiceA() }to be generated asAny other assembly registrations will then need to be marked as @mainactor in order to consume the resolver function. The structure can be extended to support other concurrency patterns like async in the future.