Parse the assembly type based on the inheritance clause #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/parse-type
branch
2 times, most recently
from
a272b9d to
b69aefd
Compare
bradfol
approved these changes
Feb 13, 2024
| @@ -0,0 +1,6 @@ | |||
| // Created by Alexander skorulis on 7/2/2024. | |||
Comment on lines
-112
to
+119
| return visitAssemblyType(node) | ||
| return visitAssemblyType(node, node.inheritanceClause) |
There was a problem hiding this comment.
That's kind of funky, is inheritanceClause not available from NamedDeclSyntax?
There was a problem hiding this comment.
Nope, it just has a name.
skorulis-ap
force-pushed
the
skorulis/parse-type
branch
from
b69aefd to
38e8fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens up the possibility of enforcing that only classes implementing
AbstractAssemblyuse abstract registrations. It will also be useful from an analysis perspective to know which assemblies are using AutoInitModuleAssembly