Fix #if config error handling #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/else-config-fix
branch
from
8ee84f7 to
4c5aab0
Compare
brianpartridge
approved these changes
Jan 25, 2024
skorulis-ap
force-pushed
the
skorulis/else-config-fix
branch
from
4c5aab0 to
de00453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version the script would error immediately when an #else condition was found. This didn't account for the possibility that that the #else was not related to a registration or import so wouldn't matter for code generation.
I've added both a unit test and some code in the example to confirm that this works as expected.
Also bumped to 0.2.6 as I want to get this into cash-ios quickly.