Clarify Default Override Behavior API #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A terminology update to clarify what the different behaviors are for default overrides.
bradfol
force-pushed
the
bradfol/override-behavior
branch
from
1604e24 to
d262046
Compare
bradfol
commented
Jan 12, 2024
Comment on lines
+71
to
+73
| /// Disable and ignore any default overrides. | ||
| /// Overrides that are _explicitly provided_ will still be used. | ||
| case disableDefaultOverrides |
There was a problem hiding this comment.
@skorulis-ap can you confirm this is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A terminology update to clarify what the different behaviors are for default overrides.