Adding support to parsing single object to a Feature #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll take a look at this soon. |
| }); | ||
|
|
||
| addOptionals(geojson, settings); | ||
| if (util.isArray(objects)) { |
There was a problem hiding this comment.
Consider swapping this out for Array.isArray and dropping the require(util). requireing a module will break this library for vanilla JavaScript in the browser. Looking at the source of util.isArray, it's just a direct export of Array.isArray, so the code should be functionally the same.
|
I left a comment for your consideration. Thanks again for the PR! |
|
Hi, I changed as per your comment, how Array.isArray missed my attention is beyond me. |
|
Thanks again for the PR. Sorry about the delay to get this in. Merging now. |
caseycesari
pushed a commit
that referenced
this pull request
Sep 18, 2016
caseycesari
pushed a commit
that referenced
this pull request
Sep 18, 2016
|
I just pushed v0.4.0 to npm, which includes this change. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to be able to store Features in a database as single entities for later concatenation into a FeatureCollection, however this module forces Features into a FeatureCollection. I added a simple check if the data parameter is an array or not to allow conversion to a single non-collection wrapped Feature.