Fix bug for rune unlock height #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the height calculation is too high at certain intervals for a given rune name length.
The crucial difference in this implementation is in what it considers to be the number from where the progress starts.
Depending on where the progress starts, the
intervalvalue will be different. So if there's an error here, the step boundaries also become wrong (which probably explains the bugs at specific intervals like 0/4, 1/4, 2/4 etc).Previous version (with bug)
"ZZZ" and "AAA" are considered to have different starting points even though they're of the same length, and get different
intervalvalues.New version
"ZZZ" and "AAA" have the same starting point (and therefore the same interval), with ZZZ having the minimum progress and AAA having the maximum progress.