chore: sync with main branch #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: *matcher result should be boolean or number* for KeyGet2 * fix: updated error hint * fix: basic keyGet2 test * fix: basic_keyget2_policy.csv (cherry picked from commit 0257078) Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
…#351) Documentation indicates that there is existance of `getUsersForRoleInDomain` and `getRolesForUserInDomain` api, but it does not yet exists. This commit implements these functions, by aliasing them to existing rbac function that had already cater for domain apis, to increase and improve dev experience. re #304 (cherry picked from commit 4896ca2)
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
|
@Gabriel-403 @kingiw @nodece please review |
|
🎉 This PR is included in version 5.14.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@Zxilly why make this PR and why make beta release? We already released v5.15.0 before your PR: https://github.com/casbin/node-casbin/releases/tag/v5.15.0 It's not reasonable to release v5.14.0-beta.4 after that. |
|
@Zxilly BTW, don't merge your own PR by yourself. We need to have a code review. |
|
@Zxilly as I said in: #352 (comment) , it's not a good idea for current state to release v6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare for casbin/casbin-editor#73
@hsluoyz @nodece plz review