Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasurementSet schema - intent and ddi attributes do not exist in xds #344

Closed
pford opened this issue Dec 4, 2024 · 1 comment · Fixed by #345
Closed

MeasurementSet schema - intent and ddi attributes do not exist in xds #344

pford opened this issue Dec 4, 2024 · 1 comment · Fixed by #345
Assignees

Comments

@pford
Copy link
Contributor

pford commented Dec 4, 2024

https://xradio.readthedocs.io/en/latest/measurement_set/schema_and_api/measurement_set_schema.html

VisibilityXds and SpectrumXds include 'intent' and 'data_description_id' attributes which do not exist when you print the xds. These should be removed from the schema or added to the xds attributes.

@FedeMPouzols
Copy link
Collaborator

Yes, thanks for catching this @pford . I think both attributes should be removed.
The real "intent" value is the "intents" field of partition_info, and note that it is a list of str. That list has all the comma separated intents found in STATE/OBS_MODE in the MSv2, when converting from MSv2. Then the DDI was dropped from the MSv4 interface and I think there should be no use for this.
These two attributes are leftovers in the schema, the converter does not use these attributes anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants