Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump web3 to 5.x #4

Closed
wants to merge 1 commit into from
Closed

Bump web3 to 5.x #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

extras_require={
'test': [
"pytest==3.3.2",
"pytest>=3.6.0",
"tox>=2.9.1,<3",
],
'lint': [
Expand Down Expand Up @@ -38,7 +38,7 @@
)

install_requires = [
'web3>=4.0.0,<5.0.0',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No CI set up on this mini project unfortunately. Were you able to test it out?

Since it doesn't look like any code changes are needed, it would be ideal to continue to support web3 v4 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran

make lint && make build-docs && pytest tests

and everything looked good, but I'll attach test evidence 👍 And yeah, I agree if there's no need to drop v4 support we should keep it in there.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, yeah, this is a very alpha project. If you take a look at "tests", you'll see what I mean.

Maybe the best solution is actually to break the dependency from web3.py on ethtoken during testing. The web3 doctest only uses the ABI, so we could just copy that ABI directly into the web3 doctest for now. That would simplify our lives and remove a dependency on a not-really-maintained project.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notably, I think that upcoming web3 v5 changes will break ethtoken, so I'm not sure I want to mark it as supported yet. (ConciseContract will go away, for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple test is better than no tests though :)

But yeah, ideally we wouldn't be creating a circular dependency... I can look into that and see what that would entail 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carver here's the PR:

ethereum/web3.py#1202

'web3>=5.0.0a1,<6.0.0',
]
if sys.platform == 'win32':
install_requires.append('pypiwin32')
Expand Down