Skip to content

Commit

Permalink
refactor: remove no-op method calls
Browse files Browse the repository at this point in the history
Since rust 1.73.0, redundant method calls that don't change anything are flagged as a warning by the compiler. This commit removes these method calls and allows the CI checks to pass.

See https://releases.rs/docs/1.73.0/ for further reference
  • Loading branch information
torives committed Oct 24, 2023
1 parent b997095 commit fce53c0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions offchain/test-fixtures/src/echo_dapp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async fn handle_advance(
.as_str()
.ok_or("Missing payload")?;
tracing::info!("Adding notice");
let notice = object! {"payload" => payload.clone()};
let notice = object! {"payload" => payload};
let req = hyper::Request::builder()
.method(hyper::Method::POST)
.header(hyper::header::CONTENT_TYPE, "application/json")
Expand All @@ -45,7 +45,7 @@ async fn handle_advance(
.as_str()
.ok_or("Missing msg_sender")?;
tracing::info!("Adding voucher");
let voucher = object! { "address" => rollup_address.clone(), "payload" => payload.clone()};
let voucher = object! { "address" => rollup_address, "payload" => payload};
let req = hyper::Request::builder()
.method(hyper::Method::POST)
.header(hyper::header::CONTENT_TYPE, "application/json")
Expand All @@ -67,7 +67,7 @@ async fn handle_inspect(
.as_str()
.ok_or("Missing payload")?;
tracing::info!("Adding report");
let report = object! {"payload" => payload.clone()};
let report = object! {"payload" => payload};
let req = hyper::Request::builder()
.method(hyper::Method::POST)
.header(hyper::header::CONTENT_TYPE, "application/json")
Expand All @@ -90,7 +90,7 @@ impl EchoDAppFixture {
loop {
tracing::info!("Sending finish");

let response = object! {"status" => status.clone()};
let response = object! {"status" => status};
let request = hyper::Request::builder()
.method(hyper::Method::POST)
.header(hyper::header::CONTENT_TYPE, "application/json")
Expand Down

0 comments on commit fce53c0

Please sign in to comment.