Fix to_json / serializable hash issue when using two uploaders on the same model. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peteonrails
commented
Jan 15, 2013
peteonrails
commented
- Added two failing tests that illustrate the problem.
- Fixed issue by changing serializable hash to use column.to_sym instead of string interpolation (which overwrites the method definition at the time mount_uploader is called)
- Fix an unrelated issue that caused my tests to fail: check that options are defined before sending :[](which nil doesn't repond to)
1. Added two failing tests that illustrate the problem. 2. Fixed issue by changing serializable hash to use column.to_sym instead of string interpolation (which overwrites the method definition at the time mount_uploader is called) 3. Fix an unrelated issue that caused my tests to fail: check that options are defined before sending :[] (which nil doesn't repond to)
rmm5t
added a commit
that referenced
this pull request
Jan 15, 2013
Fix to_json / serializable hash issue when using two uploaders on the same model.
|
Thanks Pete! |
|
This fix was just released in v0.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.