Includes optional what3words address of the workshop venue #838
Conversation
✅ Deploy Preview for workshop-template-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
I like this suggestion, thank you @pgmccann. Do you think people will understand why/when using W3W might be beneficial, or should we provide more explanation of the circumstance sin which the additional, more precise location info could be helpful?
|
I think that's a good question. The comment next to the variable assignment in the header currently contains about as much information as the others around it - I'm not sure a longer description is appropriate for an optional value. I also fear that an explanation in the text of the page might get in the way of the location information itself. Would a simple
after the location information in the page suffice? |
|
Please could you add a description of the new variable on the Customization page? I don't think that page is widely known, but it is the appropriate place for a more detailed description of the various configuration options. [Edit: source file for that page in the template: https://github.com/carpentries/workshop-template/blob/gh-pages/_extras/customization.md] |
Moves the what3words variable to sit alongside the other optional variables, for consistency with the documentation.
There was a problem hiding this comment.
Fantastic, thank you @pgmccann. (Thanks also for your patience while you waited for me to review your pull requests 🥲)
This change adds an optional what3words address field to the index page, providing organisers with another, user-friendly way of specifying the venue location.