Bugfix: Lesson title would collide with search box at certain widths. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind ammending the NEWS.md file with your contribution? |
This has been one of those frustrating bugs from the initial design that I haven't been able to pin down very well 😞 |
Robadob
force-pushed
the
bugfix_lessontitle_search_collision
branch
from
94cea23 to
29fa875
Compare
Sorted. |
Robadob
added a commit
to RSE-Sheffield/uos-varnish
that referenced
this pull request
Dec 8, 2023
|
Thank you! I think this is a good solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
The rule sits within a media breakpoint so is only active between window widths 768-1200px, otherwise that particular element is
display: none. Likewise, the search box appears to have a static size/position whilst visible (although the green magnifying glass does alot of walking about at widths >1200px). So I don't think this will introduce any new issues.Closes #84