Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catch for None type code block in lesson_check #558

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Add catch for None type code block in lesson_check #558

merged 2 commits into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. Add catch for None type code block in lesson_check 

    There are times when the AST is malformed and does not emit a class for
the code element. We do not want the parser to crash when this happens,
but we also want to notify ourselves that the AST is malformed.

This should not result in an error because as we saw in
carpentries#543, the parser itself can
cause these malformations when the lesson itself renders well. Even
though we fixed the previous issue with an updated parser, problems
still persist:
swcarpentry/r-novice-gapminder#696 (comment)

I fully admit that this is a kludge.
    @zkamvar
    zkamvar committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0554a8d View commit details
    Browse the repository at this point in the history

  2. fix syntax 

    I've removed the print condition, because it will just result in an error no matter what (sigh)
    @zkamvar
    zkamvar authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    cce6a66 View commit details
    Browse the repository at this point in the history