Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning hook + CSS class for Rmd-based lessons #455

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

fmichonneau
Copy link
Contributor

proposed implementation for #454

Preview:
Screenshot from 2020-02-06 10-31-23

@carpentries/lesson-infrastructure-committee what do you think? I'm happy to consider a different color scheme 🎨

Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The color choice seems very reasonable.

@maxim-belkin
Copy link
Contributor

maxim-belkin commented Feb 6, 2020

I didn't notice warning = hook_error in chunk-options.R when I looked at it. Nice work!

@fmichonneau fmichonneau merged commit 2f07ce1 into carpentries:gh-pages Feb 10, 2020
@fmichonneau fmichonneau deleted the fix-rmd-warning branch February 10, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants