Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callout (and other) blocks: proper font size, margins #414

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Callout (and other) blocks: proper font size, margins #414

merged 1 commit into from
Jun 19, 2019

Conversation

maxim-belkin
Copy link
Contributor

  1. Font size in callout (and other) blocks was recently changed to 17.5px which appears to look strange. In this pull request we inherit font size (from the parent)
  2. Margins in keypoint boxes are -15px, resulting in slightly different offset from the left side when compared to the code blocks. By setting margin to -10px, we make offsets in keypoint boxes and code blocks identical.

@fmichonneau
Copy link
Contributor

thanks, it looks good to me.

@fmichonneau fmichonneau merged commit 24013d3 into carpentries:gh-pages Jun 19, 2019
@maxim-belkin maxim-belkin deleted the font-size-and-margins-in-callout-and-other-code-blocks branch June 19, 2019 15:53
@maxim-belkin
Copy link
Contributor Author

Thanks, François!

@fmichonneau fmichonneau mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichonneau fmichonneau Awaiting requested review from fmichonneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-belkin @fmichonneau