Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2024 Q4 events #1726

Merged
merged 3 commits into from
Sep 4, 2024
Merged

add 2024 Q4 events #1726

merged 3 commits into from
Sep 4, 2024

Conversation

maneesha
Copy link
Contributor

@maneesha maneesha commented Sep 3, 2024

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

@maneesha
Copy link
Contributor Author

maneesha commented Sep 3, 2024

I think it's ok to merge this despite the failing check... I'll revert if not.

@brownsarahm
Copy link
Contributor

I'm not super well versed in the artifact version of using gh pages, but what I do understand I think that this error may mean that the rendered site might not reflect these changes? It's not clear to me why that step is running on a PR anyway.

but I agree it should be okay to merge this; that helps us collect more information and then we should be able to file an issue on the repo with the script code because nothing in this PR should be causing this problem. (unless the literally astronomically low probability event of a hash collision is the cause)

@maneesha
Copy link
Contributor Author

maneesha commented Sep 4, 2024

Thanks @brownsarahm - yes, nothing broke when I merged it but the changes don't render.
It is an issue with the artifact workflow. We are seeing this in other lessons as well. I will take another look tomorrow.

@froggleston
Copy link
Contributor

Fixed in sandpaper 0.16.7

@maneesha maneesha merged commit 57e4eda into main Sep 4, 2024
2 of 3 checks passed
@maneesha maneesha deleted the calendar2024Q4 branch September 4, 2024 12:46
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Auto-generated via {sandpaper}
Source  : 57e4eda
Branch  : main
Author  : maneesha <829690+maneesha@users.noreply.github.com>
Time    : 2024-09-04 12:46:12 +0000
Message : Merge pull request #1726 from carpentries/calendar2024Q4

add 2024 Q4 events
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Auto-generated via {sandpaper}
Source  : 673d5ee
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-04 12:47:10 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 57e4eda
Branch  : main
Author  : maneesha <829690+maneesha@users.noreply.github.com>
Time    : 2024-09-04 12:46:12 +0000
Message : Merge pull request #1726 from carpentries/calendar2024Q4

add 2024 Q4 events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants