Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Post Workbench transition fixes #248

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

jhlegarreta
Copy link
Contributor

Post Workbench transition fixes:

  • Remove the permalink: index.html statement for the index header.
  • Rename and move the lesson_links.md file to the root so that it can be found.
  • Fix the section relative links to the episodes in the instructor notes.
  • Fix the LaTeX equations where the transition has mistakenly introduced unnecessary additional backslashes.

Post Workbench transition fixes:
- Remove the `permalink: index.html` statement for the index header.
- Rename and move the `lesson_links.md` file to the root so that it can
  be found.
- Fix the section relative links to the episodes in the instructor
  notes.
- Fix the LaTeX equations where the transition has mistakenly introduced
  unnecessary additional backslashes.
Copy link

github-actions bot commented Feb 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/compare/md-outputs..md-outputs-PR-248

The following changes were observed in the rendered markdown documents:

 diffusion_tensor_imaging.md | 22 +++++++++++-----------
 index.md                    |  1 -
 instructor-notes.md         |  8 ++++----
 lesson_links.md => links.md |  0
 md5sum.txt                  |  8 ++++----
 5 files changed, 19 insertions(+), 20 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-02-18 02:24:37 +0000

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for sdc-bids-dmri failed.

Name Link
🔨 Latest commit 925596e
🔍 Latest deploy log https://app.netlify.com/sites/sdc-bids-dmri/deploys/65d169d1ebc18600091fdf98

github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
@jhlegarreta jhlegarreta merged commit 897bb6b into main Feb 18, 2024
3 of 7 checks passed
@jhlegarreta jhlegarreta deleted the PostTransitionFixes branch February 18, 2024 02:28
github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
Auto-generated via {sandpaper}
Source  : 897bb6b
Branch  : main
Author  : Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com>
Time    : 2024-02-18 02:28:01 +0000
Message : Merge pull request #248 from carpentries-incubator/PostTransitionFixes

BUG: Post Workbench transition fixes
github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
Auto-generated via {sandpaper}
Source  : e812621
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-02-18 02:29:40 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 897bb6b
Branch  : main
Author  : Jon Haitz Legarreta Gorroño <jon.haitz.legarreta@gmail.com>
Time    : 2024-02-18 02:28:01 +0000
Message : Merge pull request #248 from carpentries-incubator/PostTransitionFixes

BUG: Post Workbench transition fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant