-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hostnames with underscores when parsing URLs #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off; thank you so much for taking the initiative to do a merge. That's really awesome of you 👍
Can you also have a peak at the GET_EMAIL_RE
in the utils.py
as well? It looks like this:
GET_EMAIL_RE = re.compile(
r'((?P<name>[^:<]+)?[:<\s]+)?'
r'(?P<full_email>((?P<label>[^+]+)\+)?'
r'(?P<email>(?P<userid>[a-z0-9$%=_~-]+'
r'(?:\.[a-z0-9$%+=_~-]+)'
r'*)@(?P<domain>('
r'(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+'
r'[a-z0-9](?:[a-z0-9-]*[a-z0-9]))|'
r'[a-z0-9][a-z0-9-]{5,})))'
r'\s*>?', re.IGNORECASE)
I guess it should probably change to:
GET_EMAIL_RE = re.compile(
r'((?P<name>[^:<]+)?[:<\s]+)?'
r'(?P<full_email>((?P<label>[^+]+)\+)?'
r'(?P<email>(?P<userid>[a-z0-9$%=_~-]+'
r'(?:\.[a-z0-9$%+=_~-]+)'
r'*)@(?P<domain>('
r'(?:[a-z0-9](?:[a-z0-9_-]*[a-z0-9])?\.)+'
r'[a-z0-9](?:[a-z0-9_-]*[a-z0-9]))|'
r'[a-z0-9][a-z0-9_-]{5,})))'
r'\s*>?', re.IGNORECASE)
I think that's the only other spot...
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 85
Lines 10626 10626
Branches 1772 1772
=========================================
Hits 10626 10626
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding testing! That's much appreciated! Just 2 small changes is all I'd ask, otherwise it looks great!
Great work; thank you very much for the PR! 🎉 👍 |
Description:
Related issue (if applicable): #323
Checklist
flake8
)