-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run synchronous code asynchronously #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 83 83
Lines 9978 10033 +55
Branches 1626 1639 +13
=========================================
+ Hits 9978 10033 +55
Continue to review full report at Codecov.
|
Thank you for coming up with a work-around so fast, but I'm still confused why this is needed. 🤷♂️ 😕 I appreciate your hard work all the same and I see no problem with what you've done if you feel it's the solution. Next step would be to push out out another release so it can be cross referenced in HA? I'd suggest we also undo my last merge request when bumping versions? Thoughts? |
Agreed - at a minimum another release would be great, but I think you are right that we should undo the last merge request as well. I'm happy to test this and submit a PR if you could help me with a release! |
I'll get a release going by the weekend (worst case) if I can. |
@caronc mind tagging me when you do? That way I can get the other PR up |
Sure thing!🙂 |
@raman325 Apprise v0.8.9 has been release and pushed to PyPi. |
Thanks! home-assistant/core#41253 |
Description:
Related issue (if applicable): home-assistant/core#40184
As discussed in the thread, Home Assistant is detecting that synchronous I/O is being performed in the event loop (this is still occurring after this is still occurring after home-assistant/core#40213) which is not good for the reason highlighted here: home-assistant/core#40184 (comment)
This change prevents the error from my testing. I wasn't sure how to write a test for this so I didn't make any changes there but your existing tests should pass meaning worst case scenario, this is a no-op
New Service Completion Status
keywords
section of thesetup()
declaration%global common_description
Checklist
flake8
)